fix(runner): mint restart-safe session IDs (RIG-3696) - #1280
Open
rigel-mintaka wants to merge 1 commit into
Open
rigel-mintaka wants to merge 1 commit into
rigel-mintaka wants to merge 1 commit into
Conversation
Replace the Runner process-local counter with a crypto-random sess-prefixed ID allocator. Fresh session IDs remain safe for path and fabric use while avoiding collisions with durable ownership rows after a Runner restart. Keep resume_session_id reuse unchanged and update the existing binding regression to assert the new logical-ID invariant.\n\nSpec-impact: none. Refs RIG-3696\nCo-authored-by: Matt Wilkinson <matt@rigel.build>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Compass engineering docs preview: https://compass-rig-3696-restart-saf.compass-eng-docs.pages.dev Deployed from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the Runner process-local counter with a crypto-random sess-prefixed ID allocator. Fresh session IDs remain safe for path and fabric use while avoiding collisions with durable ownership rows after a Runner restart. Keep resume_session_id reuse unchanged and update the existing binding regression to assert the new logical-ID invariant.\n\nSpec-impact: none. Refs RIG-3696\nCo-authored-by: Matt Wilkinson matt@rigel.build