fix: apply a request timeout to every forge HTTP client (RIG-3585) - #6
Draft
rigel-mintaka wants to merge 1 commit into
Draft
rigel-mintaka wants to merge 1 commit into
rigel-mintaka wants to merge 1 commit into
Conversation
`reqwest` applies no request timeout by default, so a forge that accepts the connection but never responds hangs the whole process in a socket read — no output, no self-timeout, exit only on an external kill. This is the RIG-3585 symptom: `jj-vine submit` blocked in `recvfrom` on a GitHub socket. The GitHub, GitLab, Forgejo and Azure DevOps clients were each built with a bare `reqwest::Client::builder()`. Build every forge client through a shared `http_client_builder()` that applies a 30s `HTTP_TIMEOUT`, so no client can be constructed without one. Tested against a black-hole server (accepts, never responds): the timeouted client returns a timeout error in under 5s, while a `a_timeoutless_client_would_hang` control proves the pre-fix bare builder is still pending at the deadline. Spec-impact: none. Refs RIG-3585 Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
force-pushed
the
upstream-vcs/rig-3585-forge-timeout
branch
from
September 11, 2026 23:24
1a12c26 to
997aff9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reqwestapplies no request timeout by default, so a forge that accepts the connection but never responds hangs the whole process in a socket read — no output, no self-timeout, exit only on an external kill. This is the RIG-3585 symptom:jj-vine submitblocked inrecvfromon a GitHub socket. The GitHub, GitLab, Forgejo and Azure DevOps clients were each built with a barereqwest::Client::builder().Build every forge client through a shared
http_client_builder()that applies a 30sHTTP_TIMEOUT, so no client can be constructed without one. Tested against a black-hole server (accepts, never responds): the timeouted client returns a timeout error in under 5s, while aa_timeoutless_client_would_hangcontrol proves the pre-fix bare builder is still pending at the deadline.Spec-impact: none. Refs RIG-3585
Co-authored-by: Matt Wilkinson matt@rigel.build