fix: fall back to flat output when stderr is not a terminal (RIG-3585) - #7
Draft
rigel-mintaka wants to merge 1 commit into
Draft
rigel-mintaka wants to merge 1 commit into
rigel-mintaka wants to merge 1 commit into
Conversation
`run_stdout` chose the `indicatif` spinner (`InteractiveOutput`) whenever a command supported it and `verbose` was off, without checking whether stderr is a terminal. `indicatif` suppresses its own drawing on a non-tty, so a submit run with stderr piped or captured (CI, an agent shell, `2>file`) showed no progress at all and looked hung. Gate the choice on `std::io::stderr().is_terminal()` through a small pure `use_interactive_output()` helper, so a non-tty falls back to `FlatOutput`, which logs each step through `tracing` and stays visible. Unit-tested across all combinations of verbose / command-supports-interactive / tty. Spec-impact: none. Refs RIG-3585 Co-authored-by: Matt Wilkinson <matt@rigel.build>
rigel-mintaka
force-pushed
the
upstream-vcs/rig-3585-tty-progress
branch
from
September 11, 2026 23:24
94174fc to
72b2c94
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_stdoutchose theindicatifspinner (InteractiveOutput) whenever a command supported it andverbosewas off, without checking whether stderr is a terminal.indicatifsuppresses its own drawing on a non-tty, so a submit run with stderr piped or captured (CI, an agent shell,2>file) showed no progress at all and looked hung.Gate the choice on
std::io::stderr().is_terminal()through a small pureuse_interactive_output()helper, so a non-tty falls back toFlatOutput, which logs each step throughtracingand stays visible. Unit-tested across all combinations of verbose / command-supports-interactive / tty.Spec-impact: none. Refs RIG-3585
Co-authored-by: Matt Wilkinson matt@rigel.build