Repository navigation
chore(sec): xbrlkit 0.20.9 — aligned filing tables, shared 8-K assembly - #1678
Merged
Merged
Conversation
xbrlkit 0.20.9 reads an 8-K with its EX-99 exhibits in the layout this server already used, and exports the assembly as join_texts; the local copy gives way to it, so the two read an 8-K to the same character. The text cache version moves with the release's table rendering, so text cached before the deploy is not served beside text built after it.
Contributor
|
Change classification: normal — platform or application code changed. A normal change carries a documented automated review on this pull request before merge, in place of a second human approver. The |
Member
Author
|
@claude please review this PR |
|
Claude finished @jfrench9's task in 15s —— View job Review of PR #1678Verdict: looks good to merge. The diff is small and does what the description says.
Dependencies
Notes (non-blocking)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Picks up xbrlkit 0.20.9 (RoboFinSystems/xbrlkit#96), which fixes how financial tables render in filing text.
$cells and self-closing spacer cells used to push values into the wrong columns. The SECsearch-textandread-texttools render through xbrlkit, so they now get aligned tables too. This PR also moves this server's 8-K text assembly onto xbrlkit's: an 8-K, its exhibits and all, now reads the same here as it does in xbrlkit, character for character.Changes
Dependencies
xbrlkitfloor raised to>=0.20.9,<0.21.0, anduv.lockupdated. Only the xbrlkit entry changed.adapters/sec/processors/current_reports.pycurrent_report_textnow builds the 8-K text with xbrlkit'sjoin_textsinstead of its own copy of that loop. The layout is unchanged: the 8-K under## Form 8-K, then each exhibit under its own heading, each a section with its offset. No inner sections are passed, so the section list is the same as before.operations/roboledger/views/filing_text.pyTEXT_CACHE_VERSIONgoes from"2"to"3". The new table rendering changes the text and the offsets into it. Without the bump, text cached before the deploy could be served alongside text built after it for up to the 6-hour TTL, and an offset from one wouldn't land in the same place in the other.For reviewers
search-documents) also renders through xbrlkit. Filings already indexed keep the old table layout until they're reprocessed; new filings get the new one. That isn't changed here, and a reindex isn't needed, because matching is by words.Breaking Changes
None. No API, GraphQL or operations-envelope shape changes.
search-textandread-textreturn different text for tables, and different character offsets after them, but the response shapes are the same.Testing
just test-all: 16,375 passed, 42 skipped, 4 xfailed; ruff, format and basedpyright clean.0001445305-26-000059).current_report_text, run over the 8-K and EX-99.1 from the public CDN, matched xbrlkit 0.20.9 loading the same filing from EDGAR: identical text (32,917 chars) and identical section offsets (form_8kat 12,ex_99_1at 3,689). The reconciliation table's free-cash-flow row now reads| Free cash flow | $77,976 | $49,316 | $103,724 | $41,195 |, one value per period column.Certification