Recognize Keycloak REGISTER events in event log#12
Merged
Conversation
Co-authored-by: Kristaps Berzinch <kristaps@berzin.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
elifbranch inget_eventsso that Keycloak user events of typeREGISTER(emitted when an account is provisioned via an identity provider broker, e.g. CAS into theworkspace-onboardingclient) are rendered in the event log instead of bubbling up asUnrecognized type in Keycloak event.The new branch mirrors the format of the existing
LOGIN/LOGOUT/LOGIN_ERROR/LOGOUT_ERRORhandlers and produces a description likeregistered through workspace-onboarding.Testing
poetry run black --check checkpoint.pypoetry run flake8 checkpoint.pypoetry run pylint checkpoint.pypoetry run mypy --strict --scripts-are-modules checkpoint.pyregistered through workspace-onboarding.End-to-end manual reproduction of a REGISTER event would require a Keycloak identity-provider broker (CAS) connected to a real GT account, which is not reachable from the cloud VM. The change is a 2-line additive branch matching the existing patterns and all linters pass.