test: stabilize storage settings reactivity emojis/sounds tests

[nazabucciarelli]

Proposed changes (including videos or screenshots)

Apparently this test is flaky because watchMultiple has a debounce of 100ms and updateSetting has also a debounce of 100ms, which means that sometimes the storage doesn't have enough time to reinitialize. Suggested changes:

• Avoid watchMultiple to be debounced when TEST_MODE=true, this will cause the updateSetting's debounce to have enough time to reinitialize the storage.
• Regarrding the line moved upper from apps/meteor/tests/end-to-end/api/emoji-custom.ts and apps/meteor/tests/end-to-end/api/emoji-custom.ts, it's just a change to make tests faster and safer. Faster, because now the debounce parameter is false, as its following updateSetting manages the debounce. Safer, because in the case that FileSystemPath isn't empty (the default), the subsequent tests will fail.

Issue(s)

CORE-1894 Fix 'storage settings reactivity' tests flakiness from Custom Sounds/Emojis

Steps to test or reproduce

Further comments

For test purposes, verify that nothing breaks and the flakiness is gone, I've run the API Test (CE) job several times, and each of them succeeded.

• https://github.com/RocketChat/Rocket.Chat/actions/runs/22586367271/job/65440116566?pr=39172

• https://github.com/RocketChat/Rocket.Chat/actions/runs/22586367271/job/65443553318?pr=39172
• https://github.com/RocketChat/Rocket.Chat/actions/runs/22586367271/job/65445669398?pr=39172
• https://github.com/RocketChat/Rocket.Chat/actions/runs/22586367271/job/65447151142?pr=39172
• https://github.com/RocketChat/Rocket.Chat/actions/runs/22586367271/job/65448371977?pr=39172
• https://github.com/RocketChat/Rocket.Chat/actions/runs/22586367271/job/65449856033?pr=39172
• https://github.com/RocketChat/Rocket.Chat/actions/runs/22586367271/job/65451471264?pr=39172
• https://github.com/RocketChat/Rocket.Chat/actions/runs/22586367271/job/65452870193?pr=39172
• https://github.com/RocketChat/Rocket.Chat/actions/runs/22586367271/job/65454082370?pr=39172

Summary by CodeRabbit

Release Notes

• Tests
  • Refined settings timing behavior in test environments.
  • Optimized test initialization for custom sounds and emoji functionality.

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: cfd7ebd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The changes address test flakiness in storage settings reactivity tests by making debounce behavior in CachedSettings conditional on TEST_MODE (eliminating debounce during tests), and adjusting FileSystemPath setup timing in custom sounds and emoji end-to-end tests.

Changes

Cohort / File(s)	Summary
Settings Debounce Logic apps/meteor/app/settings/server/CachedSettings.ts	Introduces conditional debouncing in watchMultiple's mergeFunction: when TEST_MODE is 'true', callback invokes immediately without 100ms debounce; otherwise, debounced behavior is preserved.
Test Setup Timing apps/meteor/tests/end-to-end/api/custom-sounds.ts, apps/meteor/tests/end-to-end/api/emoji-custom.ts	Moves FileSystemPath clearing to earlier in the before hook (before Storage_Type configuration) and removes duplicate in-block cleanup, altering the sequence of setup operations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

type: chore

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The PR successfully addresses CORE-1894 by conditionally disabling watchMultiple debounce in test mode and adjusting test setup timing to resolve storage settings reactivity flakiness.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing test flakiness: modifying watchMultiple debounce behavior for TEST_MODE and adjusting test setup timing in emoji/sounds test files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: stabilizing flaky storage settings reactivity tests for emojis and sounds by addressing debounce timing issues.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.89%. Comparing base (5518503) to head (cfd7ebd).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #39172      +/-   ##
===========================================
+ Coverage    70.85%   70.89%   +0.04%     
===========================================
  Files         3208     3208              
  Lines       113426   113432       +6     
  Branches     20489    20579      +90     
===========================================
+ Hits         80363    80415      +52     
+ Misses       31012    30971      -41     
+ Partials      2051     2046       -5     

Flag	Coverage Δ
e2e	60.38% <ø> (+0.02%)	⬆️
e2e-api	47.83% <ø> (-0.95%)	⬇️
unit	71.61% <0.00%> (+0.08%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ggazzo]

What do you think about removing debouncing in development/test_mode instead of increasing CI time?

[cubic-dev-ai]

No issues found across 3 files