chore: migrate chat.starMessage and chat.unStarMessage to OpenAPI#39227
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 2c5740f The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis PR migrates the chat.starMessage and chat.unStarMessage API endpoints from globally-exported validation types and schemas to locally-scoped validation. The changes update endpoint definitions with improved OpenAPI support using chained route syntax and AJV schemas. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ahmed-n-abdeltwab
left a comment
There was a problem hiding this comment.
LGTM but also same as #39225 you need to test this local before running in the CI
|
@ggazzo 👍 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #39227 +/- ##
===========================================
- Coverage 70.76% 70.69% -0.07%
===========================================
Files 3195 3195
Lines 113106 113106
Branches 20522 20519 -3
===========================================
- Hits 80041 79963 -78
- Misses 31018 31093 +75
- Partials 2047 2050 +3
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
/jira ARCH-1464 |
Proposed changes
Migrate
chat.starMessageandchat.unStarMessageendpoints to the new OpenAPI-compatible chained route definition syntax with AJV body and response validation.Changes
apps/meteor/app/api/server/v1/chat.tsChatStarMessageLocalandChatUnstarMessageLocalchat.starMessageandchat.unStarMessagefromaddRoute()to chained.post()calls on thechatEndpointschain (afterchat.update)packages/rest-typings/src/v1/chat.tsChatStarMessageandChatUnstarMessagetypes, schemas, and validatorsChatEndpointsinterface.changeset/migrate-chat-star-unstar-message.mdminorbump for@rocket.chat/meteorand@rocket.chat/rest-typingsIssue(s)
Tracking: RocketChat/Rocket.Chat-Open-API#150
Swagger UI — chat.starMessage:

Swagger UI — chat.unStarMessage:

Summary by CodeRabbit
New Features
Documentation
Task: ARCH-2017