Repository navigation
MNT: fix develop CI with pandas 3 and pylint 4 - #1211
Merged
Merged
Conversation
pandas 3 treats py.path.local as a writable buffer and each chunk overwrites the file, leaving only the last row; tmp_path_factory avoids it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XDW574AQLHTSeBM9K172TX
Optional methods that raise NotImplementedError (polations, sensors, plots) are now reported as abstract; also move the broad-exception pragma onto the except line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XDW574AQLHTSeBM9K172TX
The API answers {"code": "temporarily_unavailable", ...} without "results",
which leaked a KeyError instead of the documented RuntimeError.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XDW574AQLHTSeBM9K172TX
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1211 +/- ##
========================================
Coverage 91.58% 91.58%
========================================
Files 132 132
Lines 18404 18404
========================================
Hits 16855 16855
Misses 1549 1549 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1209. Develop CI went red after unpinned dependencies moved: pandas 3 treats the
py.path.localfromtmpdir_factoryas a writable buffer, soto_csvoverwrote the generic surface fixtures with only their last row; they now usetmp_path_factory. Pylint 4 also reports methods that raiseNotImplementedErroras abstract, which flags every polation, sensor and plot class that leaves an optional method out, soabstract-methodis disabled and thebroad-exception-caughtpragma intools.pymoves onto theexceptline. Open-Elevation being down exposed one real bug: its error payload has noresults, sofetch_open_elevationleaked aKeyErrorinstead of the documentedRuntimeError.🤖 Generated with Claude Code
https://claude.ai/code/session_01XDW574AQLHTSeBM9K172TX