feat(http): separate request path and query string for endpoint routing - #28
Open
GreyPikachu wants to merge 2 commits into
Open
GreyPikachu wants to merge 2 commits into
GreyPikachu wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request extracts the request URL path and query string separately in
HttpRequestand routes endpoints based on the path.Motivation
Previously,
Reactor::Routecomparedrequest.targetdirectly against route literals (e.g.request.target == "/processes"). If an HTTP client appended a query string (such ascurl http://localhost:8080/processes?filter=worker), the server failed with a404 not_foundbecause the query parameters were part oftarget. Separatingpathandqueryenables URL query parameters on all HTTP endpoints without route mismatches.Changes
server/http: Addedpathandqueryfields toHttpRequestand splittargetat?.server/transport: UpdatedReactor::Routeto match againstrequest.path.tests/core: Added test case inTestHttpvalidating query string separation.Verification
TestHttp: query strings likeGET /processes?filter=webnow resolve to200with parsedpathandquery.