Update CMakeLists.txt: version and allow for modern cmake#340
Merged
lyskov merged 1 commit intoRosettaCommons:masterfrom Apr 1, 2026
Merged
Update CMakeLists.txt: version and allow for modern cmake#340lyskov merged 1 commit intoRosettaCommons:masterfrom
lyskov merged 1 commit intoRosettaCommons:masterfrom
Conversation
Update CMakeLists.txt: version and allow for modern cmake. W/o the later change the builds fail on some systems.
Member
|
Thank you @andriish !
-- Do you mean a new release tag? I can certainly create one, - please let me know. |
Contributor
Author
|
Thank you, @lyskov, yes, having a tag would be cool. |
Member
|
@andriish done, please see https://github.com/RosettaCommons/binder/releases/tag/v1.4.3 for details, - hope it helps! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update CMakeLists.txt: version and allow for modern cmake. W/o the later change the builds fail on some systems.
It would be also great to have a new tag as there were multiple changes since the last one.