Skip to content

Update CMakeLists.txt: version and allow for modern cmake#340

Merged
lyskov merged 1 commit intoRosettaCommons:masterfrom
andriish:patch-13
Apr 1, 2026
Merged

Update CMakeLists.txt: version and allow for modern cmake#340
lyskov merged 1 commit intoRosettaCommons:masterfrom
andriish:patch-13

Conversation

@andriish
Copy link
Copy Markdown
Contributor

Update CMakeLists.txt: version and allow for modern cmake. W/o the later change the builds fail on some systems.
It would be also great to have a new tag as there were multiple changes since the last one.

Update CMakeLists.txt: version and allow for modern cmake.
W/o the later change the builds fail on some systems.
@lyskov
Copy link
Copy Markdown
Member

lyskov commented Apr 1, 2026

Thank you @andriish !

It would be also great to have a new tag as there were multiple changes since the last one.

-- Do you mean a new release tag? I can certainly create one, - please let me know.

Copy link
Copy Markdown
Member

@lyskov lyskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, - thank you @andriish !

@lyskov lyskov merged commit 93efb50 into RosettaCommons:master Apr 1, 2026
11 of 14 checks passed
@andriish
Copy link
Copy Markdown
Contributor Author

Thank you, @lyskov, yes, having a tag would be cool.

@lyskov
Copy link
Copy Markdown
Member

lyskov commented Apr 15, 2026

@andriish done, please see https://github.com/RosettaCommons/binder/releases/tag/v1.4.3 for details, - hope it helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants