build: normalise amd64 optimization object names - #1092
Merged
Merged
Conversation
steadytao
changed the title
steadytao
force-pushed
the
freebsd-amd64-asm
branch
from
September 16, 2026 10:59
212bbb3 to
af3b568
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalise Autoconf's FreeBSD
amd64architecture name to thex86_64suffix used by the optimisation object variables inMakefile.in.Without this, explicitly enabling MD5 assembly, rolling-checksum SIMD or rolling-checksum assembly produces references to undefined
MD5_ASM_amd64,ROLL_SIMD_amd64andROLL_ASM_amd64variables. The required objects are therefore omitted and the final link fails with undefined symbols.The existing FreeBSD workflow now enables all three modes so the native build covers this architecture alias. Reported on the rsync mailing list.