Merged
Conversation
IanLunn
commented
Oct 17, 2025
| ``` | ||
|
|
||
| | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Not including table explaining params -- the info is not available and better to have single source of truth from linked docs
92046ec to
86bbde8
Compare
86bbde8 to
6010c75
Compare
YomiCasual
requested changes
Nov 10, 2025
Runware/Runware-base.ts
Outdated
| * @param resultKeys - The list of keys to check in order of priority. | ||
| * @returns The first string value found for the specified keys, or undefined if none found. | ||
| */ | ||
| private getResultValue(result: any, resultKeys = ["mediaUUID", "imageUUID", "videoUUID"]): string | undefined { |
Collaborator
There was a problem hiding this comment.
Lets resolve this to use status, that won't need additional change
Contributor
Author
There was a problem hiding this comment.
getResultValue has been remved. pollForAsyncResults will now check status === "success"
YomiCasual
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
inputsanddeliveryMethodto requestImageToTextgetResultUUIDtogetResultValuefrom a passed in array of keys. Previously this would search for a UUID but now it is required for caption it will search for atextkey insteadAdded to support Memories AI:
https://runware.atlassian.net/wiki/spaces/SD/pages/158138380/Memories+AI+Video+Transcription
Test scripts
image caption:
video caption:
age caption: