Skip to content

fix(warp): properly interpret floating point numbers in match_any #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Snehal-Reddy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(warp): properly interpret floating point numbers in match_any #407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions crates/cuda_std/src/warp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ macro_rules! impl_match {
}
unsafe fn match_all(mask: u32, value: Self) -> Option<u32> {
let (val, pred) = unsafe { [<match_all_ $width>](mask, value as [<u $width>]) };
pred.then(|| val)
pred.then_some(val)
}
}
}
Expand All @@ -285,8 +285,26 @@ impl_match! {
i64, 64,
u32, 32,
u64, 64,
f32, 32,
f64, 64,
}

impl WarpMatchValue for f32 {
unsafe fn match_any(mask: u32, value: Self) -> u32 {
unsafe { match_any_32(mask, value.to_bits()) }
}
unsafe fn match_all(mask: u32, value: Self) -> Option<u32> {
let (val, pred) = unsafe { match_all_32(mask, value.to_bits()) };
pred.then_some(val)
}
}

impl WarpMatchValue for f64 {
unsafe fn match_any(mask: u32, value: Self) -> u32 {
unsafe { match_any_64(mask, value.to_bits()) }
}
unsafe fn match_all(mask: u32, value: Self) -> Option<u32> {
let (val, pred) = unsafe { match_all_64(mask, value.to_bits()) };
pred.then_some(val)
}
}

#[gpu_only]
Expand Down
Loading