RNG cleanup #1127
Merged
RNG cleanup #1127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
rng-cleanup
branch
from
549c066 to
8395d10
Compare
Switches every crate except `slh-dsa` away from a direct `rand` dependency they don't need. Right now we can't publish any crate that directly depends on `rand`. Uses a consistent default strategy for RNGs: `SysRng`, sourced from the `getrandom` or as `rand::rngs::SysRng` in the case of `slh-dsa` which is actually using `rand`-specific features. If this causes too much of a slowdown, we can re-evaluate and go (back) to `ChaCha8Rng` where needed for testing.
tarcieri
force-pushed
the
rng-cleanup
branch
from
8395d10 to
479ad88
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches every crate except
slh-dsaaway from a directranddependency they don't need. Right now we can't publish any crate that directly depends onrand.Uses a consistent default strategy for RNGs:
SysRng, sourced from thegetrandomor asrand::rngs::SysRngin the case ofslh-dsawhich is actually usingrand-specific features.If this causes too much of a slowdown, we can re-evaluate and go (back) to
ChaCha8Rngwhere needed for testing.