elliptic-curve: respect byte order when padding secret key slices - #2495
Open
fmtappendf wants to merge 1 commit into
Open
fmtappendf wants to merge 1 commit into
fmtappendf wants to merge 1 commit into
Conversation
Signed-off-by: fmtappendf <fmtappendf@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SecretKey::from_slicecurrently right-aligns short inputs before decoding them. This is correct for big-endian curves, but changes the numeric value for little-endian curves such as BIGN P-256.For example, a 24-byte little-endian encoding of
1is currently padded at an offset of 8 bytes and decoded as1 << 64.Pad short inputs at the most-significant end according to
C::FIELD_ENDIANNESS: prepend zeroes for big-endian curves and append zeroes for little-endian curves.Add a regression test using a little-endian mock curve.