Skip to content

remove-vocab no longer breaks DuckDB tests #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tim-band merged 1 commit into from
Jun 30, 2026
Merged

remove-vocab no longer breaks DuckDB tests #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions datafaker/create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ def create_db_vocab(
config,
dst_engine,
)
dst_engine.dispose()
return tables_loaded


Expand Down
2 changes: 1 addition & 1 deletion tests/test_functional.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ class DBFunctionalTestCase(DBFunctionalTestCaseBase):
schema_name = "public"
alt_orm_file_path = Path("my_orm.yaml")

def atest_workflow_maximal_args(self) -> None:
def test_workflow_maximal_args(self) -> None:
"""Test the CLI workflow runs with optional arguments."""
completed_process = self.invoke(
"--verbose",
Expand Down