Speed up emap-star waveform table writes by ~50%#160
Merged
Conversation
references, thus causing Hibernate to issue unnecessary UPDATEs.
PR checklistDefault guide for a PR (if multiple PRs for the work, only keep one version of it and link to it on the other PRs)
|
skeating
approved these changes
Mar 8, 2026
skeating
left a comment
Contributor
There was a problem hiding this comment.
This is really good fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hibernate needs to be able to tell if the in-memory object has changed vs what it thinks is in the database. It uses the
equalsmethod of the Entity object to do so. If it looks like it has changed, it will issue an UPDATE to the database.Our
equalsmethod always returned false, thus causing an unecessary UPDATE shortly after we do the initial INSERT.Objects.equals(a1, a2) delegates to a1.equals(a2) in the case of Java arrays, which only tests for referential equality! The fix is to use Arrays.equals(a1, a2), which tests for equality of the values inside.
(Note that this is not part of the Waveform export pipeline that we've been actively working on the last few months. This is the waveform table inside the Postgres DB.)