Speed up Emap by adding a 3-column index #162
Merged
Merged
Conversation
PR checklistDefault guide for a PR (if multiple PRs for the work, only keep one version of it and link to it on the other PRs)
|
skeating
approved these changes
Mar 8, 2026
skeating
left a comment
Contributor
There was a problem hiding this comment.
I don't see why old indexes cannot be removed but probably want to check with somebody else with more experience of this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The query generated by
uk.ac.ucl.rits.inform.datasinks.emapstar.repos.visit_observations.VisitObservationRepository#findByHospitalVisitIdAndVisitObservationTypeIdAndObservationDatetimeis in the top ~5 of all queries by running time according to my 1-day sample.We already had single-column indexes for each of the three columns in the query, but a single index of all three makes the query run about 30% faster. I didn't check which, if any, of the single column indexes were being used.
(Can old indexes be removed?)