Conversation
Edit 1: Before the fix, the openai mockers registered a bare URL, e.g., Edit 2: Just found out about this: https://github.com/colin-b/pytest_httpx#matching-on-query-parameters Edit 3: Regex can be used in URL match queries, so I could easily add a regex which (optionally) accepts the extra api-version URL param |
|
Edit: Both failed at this time point due to unfinalized migration of google-genai-related code snippets to httpx2. Meanwhile, since there are a large overlap between those two, I believe it is better to maintain just one version (namely major) rather than the minor, so I closed the minor PR for now in favor of the major release. |
|
Nice! Can you add a summary comment (links to PRs etc) to the investigation ticket? |
This reverts commit 92a2bac.
|
If this is a POC, could you please change the PR to a draft? |
Context
Closes SAP/ai-sdk-python-backlog#10.
What this PR does and why it is needed
This PR introduces two bash scripts which do rule-based HTTPX to HTTPX2 migration.
The question whether we support a breaking change or not may depend on some aspects, e.g., some foundational dependencies might need to be fixed to the versions where httpx is essential.
Definition of Done