Skip to content

feat: add reasoning content to AssistantChatMessage and StreamDelta - #160

Merged
mwien merged 2 commits into
mainfrom
add-reasoning-content
Sep 23, 2026
Merged

mwien merged 2 commits into
mainfrom
add-reasoning-content

Conversation

@mwien

@mwien mwien commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

Context

Closes SAP/ai-sdk-python-backlog#41.

What this PR does and why it is needed

The reasoning_content field was missing in two response classes: AssistantChatMessage and StreamDelta.

Definition of Done

  • Code is tested (Unit, Integration, E2E)
    • NOTE: orchestration_v2/models/response.py has no unit tests all (unless I missed something). Because of the minimal change I did not add any tests for StreamDelta.
  • Error handling created / updated & covered by the tests above
  • Documentation updated
    • Only Public APIs are allowed to be used in documentation/tutorials/sample code
  • (Optional) Aligned changes with the JS/TS and Java SDK
  • (Optional) Release notes updated -->

@hyperspace-pr-bot

Copy link
Copy Markdown

👋 Hi — I'm PR Bot, your SAP code review assistant.

I'll automatically review your pull requests for code quality, security, and SAP compliance. Get an overview of what I do →

What I do

  • Summarize your pull request changes
  • Review code for quality, correctness, and reliability
  • Suggest fixes when a pipeline job fails

Key commands

Command Description
/review [--all] Trigger a code review. Add --all to include files excluded by excluded_paths.
/summarize Generate a PR summary
/ask <question> Ask about the current changes
/help See all available commands
Configure me for your team

Create .hyperspace/pull_request_bot.json in your repository:

{
  "$schema": "https://devops-insights-pr-bot.cfapps.eu10-004.hana.ondemand.com/schema/pull_request_bot.json",
  "features": {
    "control_panel": false,
    "summarize": {
      "auto_generate_summary": true,
      "auto_insert_summary": true,
      "auto_run_on_draft_pr": true,
      "use_custom_summarize_prompt": false,
      "use_custom_summarize_output_template": false,
      "excluded_paths": [],
      "auto_exclude_authors": []
    },
    "review": {
      "auto_generate_review": true,
      "auto_run_on_draft_pr": false,
      "use_custom_review_focus": false,
      "excluded_paths": [],
      "auto_exclude_authors": []
    },
    "sonar_fix": {
      "enable": true,
      "excluded_rules": []
    },
    "pipeline_fix": {
      "enable": true
    }
  },
  "excluded_paths": []
}

Full configuration reference →

*This introduction message will be shown to you only once, you will not see it in future PRs.

yamaceay
yamaceay previously approved these changes Sep 22, 2026

@yamaceay yamaceay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yamaceay yamaceay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving again after fixing the merge conflict

@mwien
mwien merged commit 8a19d5d into main Sep 23, 2026
24 of 25 checks passed
@mwien
mwien deleted the add-reasoning-content branch September 23, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants