fix: added newlines to satisfy unix convention - #65
Merged
Merged
Conversation
Contributor
Author
|
Maybe we can configure a pre-commit linter to add newlines in the future automatically soon, also within the scope of this PR. What do you think? |
Contributor
Good idea, also it doesn't have to be a pre-commit hook locally, it can also be a workflow to check all the rules and locally newline will be covered by formatter like Ruff? I guess currently there is only pylint as the linter, no auto formatter like Ruff or Black configured. |
ZhongpinWang
approved these changes
Aug 14, 2026
ZhongpinWang
left a comment
Contributor
There was a problem hiding this comment.
Thanks for improving the code base!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to satisfy the Unix file convention by adding newlines
\nto the files with no newlines.For detection, we can run the following command:
with 320 out of 861 files not having newline at the end of the file.
After running:
The number of no-newline files dropped from 320 to 0, and the issue is resolved.
Note: Other directories or top-level scripts are already OK.