Conversation
OscarDDD
requested review from
BrigittaK307
and
a lite review from Copilot
and removed request for
Copilot
September 23, 2026 05:27
BrigittaK307
requested changes
Sep 23, 2026
alpkom
requested changes
Sep 23, 2026
alpkom
left a comment
alpkom
left a comment
There was a problem hiding this comment.
Looks good to me overall.
However two changes still needed:
- Add the RELEASE_NOTES.md file from gen package here, as well.
- The overview.mdx file needs to be synced with the README_sphynx file from the source code repo:
https://github.com/SAP/ai-sdk-python/blob/main/packages/gen/README_sphynx.md
And since we're syncing them now, I'd suggest to clean up the README a bit before applying the changes to overview. Check this PR as suggestion:
SAP/ai-sdk-python#161
Contributor
Author
I keep and update package dependency section based on the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Has Changed?
This is related to the https://github.com/SAP/ai-sdk-python-backlog/issues/45
Add the missing text and code to the current version.
Feature Scope
These changes are only aim to make sure there is no big difference between the old docs and current docs. The correctness of the code will be evaluated again afterwards.