chore(ci): Migrate repository check to is-fork check in setup action#6526
Open
davidkna-sap wants to merge 3 commits intomainfrom
Open
chore(ci): Migrate repository check to is-fork check in setup action#6526davidkna-sap wants to merge 3 commits intomainfrom
davidkna-sap wants to merge 3 commits intomainfrom
Conversation
marikaner
requested changes
Apr 28, 2026
Comment on lines
+50
to
+51
| elif [[ -n "$REGISTRY_TOKEN" ]]; then | ||
| echo "url=https://common.repositories.cloud.sap/artifactory/api/npm/build.releases.npm/" >> $GITHUB_OUTPUT |
Contributor
There was a problem hiding this comment.
I think it would be better to check github.event.pull_request.head.repo.fork => https://docs.github.com/en/webhooks/webhook-events-and-payloads#pull_request (see Properties of pull_request and navigate the tree > head > repo > fork (boolean))
Member
Author
There was a problem hiding this comment.
I've migrated the check, hopefully that condition works better.
davidkna-sap
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even for forked repos,
github.repositoryevaluates to the parent's repo name, leading to unintended failures.