Skip to content

Domain External-Name Handling#267

Open
Kukkerem wants to merge 3 commits intomainfrom
external-name-comp-domain
Open

Domain External-Name Handling#267
Kukkerem wants to merge 3 commits intomainfrom
external-name-comp-domain

Conversation

@Kukkerem
Copy link
Copy Markdown
Collaborator

@Kukkerem Kukkerem commented Apr 28, 2026

Closes: #239

  1. Implemented correct external-name handling in Create and Delete function
  2. Adapted Unit Tests for Create and Delete function
  3. Created E2E Import Test
  4. Created Upgrade Test for External-Name Behavior
  5. Added documentation

@Kukkerem Kukkerem had a problem deploying to pr-e2e-no-approval April 28, 2026 12:06 — with GitHub Actions Failure
@Kukkerem Kukkerem had a problem deploying to pr-e2e-no-approval April 28, 2026 12:55 — with GitHub Actions Failure
@Kukkerem Kukkerem temporarily deployed to pr-e2e-no-approval April 28, 2026 15:29 — with GitHub Actions Inactive
@Kukkerem Kukkerem requested a review from SatabdiG April 28, 2026 16:21
@Kukkerem Kukkerem self-assigned this Apr 28, 2026
SatabdiG
SatabdiG approved these changes Apr 30, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@SatabdiG SatabdiG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

Comment thread internal/clients/domain/domain.go
Comment thread internal/clients/domain/domain_test.go
Comment thread internal/controller/domain/controller_test.go Outdated
Kukkerem added 3 commits May 6, 2026 13:13
@Kukkerem
feat(domain): implement ADR-compliant external-name handling
6edad20 
Signed-off-by: Zoltan Szabo <zoltan.szabo03@sap.com>
@Kukkerem
fix(domain): remove org filter from FindDomainBySpec
19a75a0 
Signed-off-by: Zoltan Szabo <zoltan.szabo03@sap.com>
@Kukkerem
test(domain): address review comments in test naming and error types
32742b0 
Signed-off-by: Zoltan Szabo <zoltan.szabo03@sap.com>
@Kukkerem Kukkerem force-pushed the external-name-comp-domain branch from 15f22f5 to 32742b0 Compare May 6, 2026 11:21
@Kukkerem Kukkerem had a problem deploying to pr-e2e-no-approval May 6, 2026 11:21 — with GitHub Actions Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SatabdiG SatabdiG SatabdiG approved these changes

Assignees

@Kukkerem Kukkerem

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[TASK] External Name (Domain): Ensure ADR Compliance

2 participants

@Kukkerem @SatabdiG