chore(feature): knowledge hub Telemetry Setup#68
chore(feature): knowledge hub Telemetry Setup#68aakankshagupta1994 wants to merge 51 commits intomainfrom
Conversation
|
kranthie-sap
left a comment
There was a problem hiding this comment.
Hi @aakankshagupta1994, please see my review comments. Also, please update the ide-extension telemetry unit tests to use the right telemetry events send from the webapp. Also, please add unit tests in the webapp to simulate clicks and check if the action is triggered.
|
@aakankshagupta1994: I just noticed that sonar reported a bug in the PR - https://sonarcloud.io/project/issues?id=SAP_knowledge-hub-extension&pullRequest=68&resolved=false&types=BUG |
|
@kranthie-sap The requested changes are added. Can you please verify? |
Klaus-Keller
left a comment
There was a problem hiding this comment.
@kranthie-sap @aakankshagupta1994
the two tracked telemetry events in this pull request are for links that are clicked and need a new redux action, so far so good. However, it is often the case that an existing redux action can be used as trigger to track telemetry data. In this case, to avoid polluting application logic with telemetry events an alternative is to add a telemetry middleware and filter/map redux actions that should be tracked.
We can discuss this along with this PR or postpone the discussion until more events are added, whatever you prefer.
|
Kudos, SonarCloud Quality Gate passed! |
Klaus-Keller
left a comment
There was a problem hiding this comment.
Thanks for addressing all my comments. There are no open issues that I can see, from my side this is approved.








Issue
#35
#36
Description
TBI - Provide telemetry data for the tutorials and tutorial tags opened
TBI - Provide telemetry data for the blogs and tags opened
FILL IN DETAILS HERE
Checklist for Pull Requests