Skip to content

Match InitSprites #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JaceCear merged 1 commit into from
Nov 3, 2026
Merged

Match InitSprites #32

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
245 changes: 124 additions & 121 deletions src/game/sa3/character_select.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,136 +426,139 @@ void SetupPositions(CharacterSelect *cs)
cs->unkC[PLAYER_2] = gPlayers[partnerIndex].charFlags.character;
}

// TODO: Fake-match!
// (100.00&) https://decomp.me/scratch/Y518W
static void InitSprites(CharacterSelect *cs)
{
TileInfo2 *ti;
#ifndef NON_MATCHING
register Sprite *s asm("r0");
#else
Sprite *s;
#endif
u16 language;
u8 *vram = OBJ_VRAM0;
s32 index, index2;
s32 unk5;

s = &cs->sprC4;
s->tiles = vram;
vram += 0x5A0;
s->anim = gTileInfo_CharSelect3_HeaderBackdrop[0].anim;
s->variant = gTileInfo_CharSelect3_HeaderBackdrop[0].variant;
s->prevVariant = -1;
s->x = ((s32)cs->qUnk2C >> 8);
s->y = ((s32)cs->qUnk30 >> 8);
s->oamFlags = 0x40;
s->animCursor = 0;
s->qAnimDelay = 0;
s->animSpeed = 0x10;
s->palId = 0;
s->frameFlags = 0;
UpdateSpriteAnimation(s);

s = &cs->spr9C;
s->tiles = vram;
vram += 50 * TILE_SIZE_4BPP;
s->anim = gTileInfo_CharSelect3_TeamDescriptions[cs->language * 8].anim;
s->variant = gTileInfo_CharSelect3_TeamDescriptions[cs->language * 8].variant;
s->prevVariant = -1;
s->x = I(cs->qTxtSelectAPlayerX);
s->y = I(cs->qTxtSelectAPlayerY);
s->oamFlags = 0;
s->animCursor = 0;
s->qAnimDelay = 0;
s->animSpeed = 0x10;
s->palId = 0;
s->frameFlags = 0;
UpdateSpriteAnimation(s);
{
Sprite *s = &cs->sprC4;

@idefix02 idefix02 Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regalloc demands separate Sprite* variables here, but perhaps you'd prefer to have a "Sprite *s1, *s2, *s3, etc." declaration at the top of the function instead, and get rid of block scopes?

s->tiles = vram;
vram += 45 * TILE_SIZE_4BPP;
s->anim = gTileInfo_CharSelect3_HeaderBackdrop[0].anim;
s->variant = gTileInfo_CharSelect3_HeaderBackdrop[0].variant;
s->prevVariant = -1;
s->x = I(cs->qUnk2C);
s->y = I(cs->qUnk30);
s->oamFlags = 0x40;
s->animCursor = 0;
s->qAnimDelay = 0;
s->animSpeed = SPRITE_ANIM_SPEED(1.0);
s->palId = 0;
s->frameFlags = 0;
UpdateSpriteAnimation(s);
}

s = &cs->spr18C;
s->tiles = vram;
vram += 4 * TILE_SIZE_4BPP;
s->anim = ANIM_CHARSELECT_NAMETAG_NAMES_JP;
s->variant = 5;
s->prevVariant = -1;
s->x = DISPLAY_CENTER_X;
s->y = I(cs->qNameTagPos[CS_CHARID_PLAYER].y);
s->oamFlags = 0;
s->animCursor = 0;
s->qAnimDelay = 0;
s->animSpeed = 0x10;
s->palId = 0;
s->frameFlags = 0;
UpdateSpriteAnimation(s);
{
Sprite *s = &cs->spr9C;
s->tiles = vram;
vram += 50 * TILE_SIZE_4BPP;
s->anim = gTileInfo_CharSelect3_TeamDescriptions[cs->language * 8].anim;
s->variant = gTileInfo_CharSelect3_TeamDescriptions[cs->language * 8].variant;
s->prevVariant = -1;
s->x = I(cs->qTxtSelectAPlayerX);
s->y = I(cs->qTxtSelectAPlayerY);
s->oamFlags = 0;
s->animCursor = 0;
s->qAnimDelay = 0;
s->animSpeed = SPRITE_ANIM_SPEED(1.0);
s->palId = 0;
s->frameFlags = 0;
UpdateSpriteAnimation(s);
}

s = &cs->spr74;
cs->spr74.tiles = vram;
vram += 16 * TILE_SIZE_4BPP;
s->anim = gUnknown_080D8F08[0].anim;
s->variant = gUnknown_080D8F08[0].variant;
s->prevVariant = -1;
s->x = I(cs->qUnk5C);
s->y = I(cs->qUnk60);
s->oamFlags = -0x40;
s->animCursor = 0;
s->qAnimDelay = 0;
s->animSpeed = 0x10;
s->palId = 0;
s->frameFlags = 0;
UpdateSpriteAnimation(s);
{
Sprite *s = &cs->spr18C;
s->tiles = vram;
vram += 4 * TILE_SIZE_4BPP;
s->anim = ANIM_CHARSELECT_NAMETAG_NAMES_JP;
s->variant = 5;
s->prevVariant = -1;
s->x = DISPLAY_CENTER_X;
s->y = I(cs->qNameTagPos[CS_CHARID_PLAYER].y);
s->oamFlags = 0;
s->animCursor = 0;
s->qAnimDelay = 0;
s->animSpeed = SPRITE_ANIM_SPEED(1.0);
s->palId = 0;
s->frameFlags = 0;
UpdateSpriteAnimation(s);
}

s = &cs->sprEC;
language = (cs->language == 0) ? 0 : 1;
index2 = (gCharSelect_DisplayOrder[cs->listIndex[CS_CHARID_PLAYER]]);
s->tiles = vram;
vram += 14 * TILE_SIZE_4BPP;
s->anim = gTileInfo_CharSelect3_NameTagNames[index2 += language * sizeof(TileInfo2)].anim;
s->variant = gTileInfo_CharSelect3_NameTagNames[index2].variant;
s->prevVariant = -1;
s->x = I(cs->qNameTagPos[CS_CHARID_PLAYER].x);
s->y = I(cs->qNameTagPos[CS_CHARID_PLAYER].y);
s->oamFlags = 0;
s->animCursor = 0;
s->qAnimDelay = 0;
s->animSpeed = 0x10;
s->palId = 0;
s->frameFlags = 0;
UpdateSpriteAnimation(s);
{
Sprite *s = &cs->spr74;
s->tiles = vram;
vram += 16 * TILE_SIZE_4BPP;
s->anim = gUnknown_080D8F08[0].anim;
s->variant = gUnknown_080D8F08[0].variant;
s->prevVariant = -1;
s->x = I(cs->qUnk5C);
s->y = I(cs->qUnk60);
s->oamFlags = -0x40;
s->animCursor = 0;
s->qAnimDelay = 0;
s->animSpeed = SPRITE_ANIM_SPEED(1.0);
s->palId = 0;
s->frameFlags = 0;
UpdateSpriteAnimation(s);
}

s = &cs->spr13C;
language = (cs->language == 0) ? 0 : 1;
index2 = (gCharSelect_DisplayOrder[cs->listIndex[CS_CHARID_PLAYER]]);
s->tiles = vram;
vram += 14 * TILE_SIZE_4BPP;
s->anim = gTileInfo_CharSelect3_NameTagNames[index2 += language * sizeof(TileInfo2)].anim;
s->variant = gTileInfo_CharSelect3_NameTagNames[index2].variant;
s->prevVariant = -1;
s->x = I(cs->qNameTagPos[CS_CHARID_PARTNER].x);
s->y = I(cs->qNameTagPos[CS_CHARID_PARTNER].y);
s->oamFlags = 0;
s->animCursor = 0;
s->qAnimDelay = 0;
s->animSpeed = 0x10;
s->palId = 0;
s->frameFlags = 0;
UpdateSpriteAnimation(s);
{
Sprite *s = &cs->sprEC;
u16 language = (cs->language == 0) ? 0 : 1;
s32 index = gCharSelect_DisplayOrder[cs->listIndex[CS_CHARID_PLAYER]];
s->tiles = vram;
vram += 14 * TILE_SIZE_4BPP;
s->anim = gTileInfo_CharSelect3_NameTagNames[index + language * sizeof(TileInfo2)].anim;
s->variant = gTileInfo_CharSelect3_NameTagNames[index + language * sizeof(TileInfo2)].variant;
s->prevVariant = -1;
s->x = I(cs->qNameTagPos[CS_CHARID_PLAYER].x);
s->y = I(cs->qNameTagPos[CS_CHARID_PLAYER].y);
s->oamFlags = 0;
s->animCursor = 0;
s->qAnimDelay = 0;
s->animSpeed = SPRITE_ANIM_SPEED(1.0);
s->palId = 0;
s->frameFlags = 0;
UpdateSpriteAnimation(s);
}

s = &cs->sprNameTagBack;
s->tiles = vram;
vram += 24 * TILE_SIZE_4BPP;
s->anim = gUnknown_080D8EF8[0].anim;
s->variant = gUnknown_080D8EF8[0].variant;
s->prevVariant = -1;
s->x = I(cs->qNameTagPos[CS_CHARID_PLAYER].x);
s->y = I(cs->qNameTagPos[CS_CHARID_PLAYER].y);
s->oamFlags = SPRITE_OAM_ORDER(1);
s->animCursor = 0;
s->qAnimDelay = 0;
s->animSpeed = 0x10;
s->palId = 0;
s->frameFlags = 0;
UpdateSpriteAnimation(s);
{
Sprite *s = &cs->spr13C;
u16 language = (cs->language == 0) ? 0 : 1;
s32 index = gCharSelect_DisplayOrder[cs->listIndex[CS_CHARID_PLAYER]];
s->tiles = vram;
vram += 14 * TILE_SIZE_4BPP;
s->anim = gTileInfo_CharSelect3_NameTagNames[index + language * sizeof(TileInfo2)].anim;
s->variant = gTileInfo_CharSelect3_NameTagNames[index + language * sizeof(TileInfo2)].variant;
s->prevVariant = -1;
s->x = I(cs->qNameTagPos[CS_CHARID_PARTNER].x);
s->y = I(cs->qNameTagPos[CS_CHARID_PARTNER].y);
s->oamFlags = 0;
s->animCursor = 0;
s->qAnimDelay = 0;
s->animSpeed = SPRITE_ANIM_SPEED(1.0);
s->palId = 0;
s->frameFlags = 0;
UpdateSpriteAnimation(s);
}

{
Sprite *s = &cs->sprNameTagBack;
s->tiles = vram;
vram += 24 * TILE_SIZE_4BPP;
s->anim = gUnknown_080D8EF8[0].anim;
s->variant = gUnknown_080D8EF8[0].variant;
s->prevVariant = -1;
s->x = I(cs->qNameTagPos[CS_CHARID_PLAYER].x);
s->y = I(cs->qNameTagPos[CS_CHARID_PLAYER].y);
s->oamFlags = SPRITE_OAM_ORDER(1);
s->animCursor = 0;
s->qAnimDelay = 0;
s->animSpeed = SPRITE_ANIM_SPEED(1.0);
s->palId = 0;
s->frameFlags = 0;
UpdateSpriteAnimation(s);
}

cs->tilesCharacters[CS_CHARID_ACTIVE] = vram;
}
Expand Down