fix(codex): release active thread writers on dispose - #582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Teardown relied on locally observed active turn IDs. If Poracode missed a concurrent or continuation turn, it could unsubscribe while that Codex turn kept running in a pooled app-server process. The provider thread retained its writer, so a later
thread/resumefailed withthread … already has an active writer.Impact
Reopening a Codex GUI thread no longer intermittently fails because an unobserved turn survived teardown. Replacement sessions are protected from interruption if ownership changes while teardown is in flight.
Validation
pnpm exec vitest run src/supervisor/agents/codex/codex.test.ts src/supervisor/agents/codex/appServerRpc.test.ts src/supervisor/agents/codex/serverPool.test.ts— 3 files, 161 tests passedpnpm run typecheckpnpm run lintpnpm exec oxfmt --check src/supervisor/agents/codex/acp.ts src/supervisor/agents/codex/codex.test.tsgit diff --check