remove deprecation warnings #84
Merged
Merged
Conversation
linuxmaniac
force-pushed
the
vseva_warn
branch
2 times, most recently
from
92af6c3 to
4f77dd3
Compare
Contributor
Author
|
@goodboy rebased to trigger CI, all OK |
Contributor
Author
|
@goodboy test_confpy_hooks check still fails here too :-( |
linuxmaniac
force-pushed
the
vseva_warn
branch
2 times, most recently
from
e8909b7 to
b4f5757
Compare
Member
|
@linuxmaniac again looks great to me. Can we rebase this onto latest Then I can give it a proper review 🏄🏼 |
goodboy
approved these changes
Dec 18, 2022
goodboy
left a comment
goodboy
left a comment
Member
There was a problem hiding this comment.
Ye, reviewed quickly anyway and looks good.
> pysipp/utils.py:2: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses > import imp # XXX py2.7
> pysipp/report.py:77: > DeprecationWarning: The 'warn' method is deprecated, use 'warning' > instead > emit( > > pysipp/launch.py:134: > DeprecationWarning: The 'warn' method is deprecated, use 'warning' > instead > log.warn(
linuxmaniac
force-pushed
the
vseva_warn
branch
from
b4f5757 to
5a92de7
Compare
Contributor
Author
|
@goodboy rebased |
Member
|
@linuxmaniac 👍🏼 Once this lands you should check out #87 too 😉 |
goodboy
approved these changes
Dec 19, 2022
goodboy
left a comment
goodboy
left a comment
Member
There was a problem hiding this comment.
Looks good.
Glad to see the module loading updated and some tests to match 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.