Skip to content

Fix WasmJS/JS/Native compile: replace putIfAbsent with common idiom #485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michalharakal merged 1 commit into from
Apr 13, 2026
Merged

Fix WasmJS/JS/Native compile: replace putIfAbsent with common idiom #485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...pile/skainet-compile-hlo/src/commonMain/kotlin/sk/ainet/compile/hlo/StableHloConverter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,17 +200,22 @@ public class StableHloConverter(
* `name -> encoding` map of every tensor that carries a non-null
* [TensorEncoding]. Duplicates (the same name appearing in multiple
* nodes) collapse to a single entry — first-writer-wins.
*
* Implementation note: uses an explicit `!in` check rather than
* `MutableMap.putIfAbsent` because the latter is a JVM-only
* extension and does not exist in Kotlin common-stdlib for WasmJS
* / JS / Native targets.
*/
private fun collectTensorEncodings(nodes: List<GraphNode>): Map<String, TensorEncoding> {
val result = linkedMapOf<String, TensorEncoding>()
for (node in nodes) {
for (spec in node.outputs) {
val encoding = spec.tensorEncoding ?: continue
result.putIfAbsent(spec.name, encoding)
if (spec.name !in result) result[spec.name] = encoding
}
for (spec in node.inputs) {
val encoding = spec.tensorEncoding ?: continue
result.putIfAbsent(spec.name, encoding)
if (spec.name !in result) result[spec.name] = encoding
}
}
return result
Expand Down
Loading