Build: drop js() from skainet-io-iree-params (closes #527)#528
Merged
michalharakal merged 1 commit intodevelopfrom Apr 19, 2026
Merged
Build: drop js() from skainet-io-iree-params (closes #527)#528michalharakal merged 1 commit intodevelopfrom
michalharakal merged 1 commit intodevelopfrom
Conversation
Fixes `./gradlew allTests` configuration failure on develop: the module declared a `js()` target but depends on :skainet-compile-hlo, which does not publish one. Gradle resolution fails with a platform-type variant mismatch (consumer wants `js`, producer only has `wasm`). Wasm targets stay — they use a distinct `wasm` platform attribute that :skainet-compile-hlo does publish. This fix was originally part of PR #525 (commit fdd378e) but got dropped during the merge; only the first commit landed. Re-applying as a standalone, narrow fix. Closes #527 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./gradlew allTestsfails on develop with a platform-type variant mismatch:skainet-io-iree-paramsdeclaresjs()but its transitive dep:skainet-compile:skainet-compile-hlodoes not publish a JS target.js(). Wasm targets keep working (they use thewasmplatform attribute, which the upstream dep does publish).Background
This fix was originally committed to PR #525's branch (commit
fdd378e7) but only the first commit made it into the merge, so develop landed in a broken state. Re-applying as a narrow standalone fix.Test plan
./gradlew allTestspasses — 1056 tasks, 28 executed + 1028 cached, all green../gradlew :skainet-io:skainet-io-iree-params:jvmTeststill green.Closes #527.
🤖 Generated with Claude Code