Merged
Conversation
… simulator, and docker image for building wheels
jamesaboyle
commented
Jul 1, 2025
Collaborator
Author
jamesaboyle
left a comment
jamesaboyle
left a comment
There was a problem hiding this comment.
Awesome work :D just a few minor suggestions, but no reason we can't merge it!
| on: [push, pull_request] | ||
|
|
||
| jobs: | ||
| build_wheels: |
Collaborator
Author
There was a problem hiding this comment.
I think here we can add an if: clause, to check if the repository is jamesaboyle/SANA-FE (my local mirror)
ci/check_build.rb
Outdated
| end | ||
|
|
||
| #set clang path | ||
| clang_path = "/home/jab23579/useful/clang-20/bin/clang++" |
Collaborator
Author
There was a problem hiding this comment.
It might be good if the clang and GCC paths can just be pulled from an environment variable, so we don't have to commit the full path :)
Previously moved some code to be inlined in pipeline.hpp Simply remove the conflicts due to this missing code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include CI features developed during May and June by Zach and Arsen. These include a new check script with several custom checkers.
[WIP] The GitHub actions / workflow for wheel building is current a WIP. However, we have included a wheel building Docker image for now (only with Linux support).