fix: raise SQLMeshError when invalidating a nonexistent environment#5833
Open
noezhiya-dot wants to merge 3 commits into
Open
fix: raise SQLMeshError when invalidating a nonexistent environment#5833noezhiya-dot wants to merge 3 commits into
noezhiya-dot wants to merge 3 commits into
Conversation
The sqlmesh invalidate command previously accepted any environment name, even if the environment did not exist, silently reporting success. Now it checks that the environment exists first and raises a clear SQLMeshError if it does not. Fixes SQLMesh#5621 Signed-off-by: Nuzia Rijki <noezhiya@gmail.com>
mday-io
reviewed
Jun 12, 2026
| name = Environment.sanitize_name(name) | ||
| stored_environment = self.state_sync.get_environment(name) | ||
| if not stored_environment: | ||
| raise SQLMeshError(f"Environment '{name}' does not exist.") |
Collaborator
There was a problem hiding this comment.
I see a warning as a better option here instead of an error. If there's some CICD script running, we wouldn't want them to fail when they're trying to ensure proper cleanup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
sqlmesh invalidatecommand previously accepted any environment name, even if the environment did not exist, silently reporting success. Now it checks that the environment exists first and raises a clearSQLMeshErrorif it does not.Test Plan
test_invalidate_environment_nonexistent_raisesto confirm that callinginvalidate_environmenton a nonexistent environment raisesSQLMeshErrorand does not callinvalidate_environmenton the state sync.Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO