Fix dbt source identifiers with dots#5835
Closed
nkwork9999 wants to merge 1 commit into
Closed
Conversation
Signed-off-by: nk <nkwork1234@gmail.com>
Collaborator
|
@nkwork9999 any difference from this PR? |
Author
|
I overlooked it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5762.
Preserves identifier quoting when dbt source identifiers contain dots or spaces so names like
FILENAME.CSVrender as a single quoted identifier instead of being parsed as extra table path segments.Test Plan
uv run --extra dev --extra web --extra slack --extra dlt --extra lsp make styleuv run --extra dev --extra web --extra slack --extra dlt --extra lsp make fast-testuv run --extra dbt --with dbt-duckdb --with pytest --with pytest-mock --with pytest-xdist pytest tests/dbt/test_config.py::test_quoting tests/dbt/test_config.py::test_source_config_canonical_name_quotes_identifier_with_dot_or_space -qChecklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO