Skip to content

Fix dbt source identifiers with dots#5835

Closed
nkwork9999 wants to merge 1 commit into
SQLMesh:mainfrom
nkwork9999:fix/source-dot-identifier-quoting
Closed

Fix dbt source identifiers with dots#5835
nkwork9999 wants to merge 1 commit into
SQLMesh:mainfrom
nkwork9999:fix/source-dot-identifier-quoting

Conversation

@nkwork9999

Copy link
Copy Markdown

Description

Fixes #5762.

Preserves identifier quoting when dbt source identifiers contain dots or spaces so names like FILENAME.CSV render as a single quoted identifier instead of being parsed as extra table path segments.

Test Plan

  • uv run --extra dev --extra web --extra slack --extra dlt --extra lsp make style
  • uv run --extra dev --extra web --extra slack --extra dlt --extra lsp make fast-test
  • uv run --extra dbt --with dbt-duckdb --with pytest --with pytest-mock --with pytest-xdist pytest tests/dbt/test_config.py::test_quoting tests/dbt/test_config.py::test_source_config_canonical_name_quotes_identifier_with_dot_or_space -q

Checklist

  • I have run make style and fixed any issues
  • I have added tests for my changes (if applicable)
  • All existing tests pass (make fast-test)
  • My commits are signed off (git commit -s) per the DCO

Signed-off-by: nk <nkwork1234@gmail.com>
@StuffbyYuki

Copy link
Copy Markdown
Collaborator

@nkwork9999 any difference from this PR?

@nkwork9999

Copy link
Copy Markdown
Author

I overlooked it!
Thank you.

@nkwork9999 nkwork9999 closed this Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SourceConfig.canonical_name() fails with ValueError: too many values to unpack for source identifiers containing dots

2 participants