Skip to content

Complete Budget Buddy walkthrough hardening - #7

Closed
SQLtattoo wants to merge 2 commits into
mainfrom
demo/budget-buddy-walkthrough
Closed

SQLtattoo wants to merge 2 commits into
mainfrom
demo/budget-buddy-walkthrough

Conversation

@SQLtattoo

Copy link
Copy Markdown
Owner

Summary

  • complete the Docker and GitHub Actions demo paths
  • harden file access and budget calculation edge cases
  • simplify transaction category aggregation while preserving the duplicate-detection exercise
  • add focused calculator, file-handler, processor, and data-table tests
  • enforce a consistent 80% coverage gate and align trainer/agent documentation with the completed walkthrough state
  • add the repository refactor agent customization

Validation

  • python main.py
  • pytest -q
  • 30 tests passed
  • 85.63% coverage; 80% gate passed

Remaining intentional gaps

  • O(n^2) duplicate detection remains for the performance-refactoring exercise
  • transaction validation and malformed CSV handling remain teaching tasks
  • feature-generation TODOs remain documented in INTENTIONAL_ISSUES.md

Finish CI and container setup, harden file and calculator edge cases, improve transaction processing, add focused tests with an 80% coverage gate, and align the demo documentation and agent customization assets.
Point setup-python at requirements-test.txt so the CI cache step can initialize before dependency installation.
@SQLtattoo

Copy link
Copy Markdown
Owner Author

@copilot review the diff

Copilot AI commented Oct 12, 2026

Copy link
Copy Markdown

@copilot review the diff

Found one issue: both sort paths coerce falsey values to "" (data_table.py:157 and data_table.py:372). Sorting numeric values that include 0 or None alongside other numbers then compares strings and numbers and raises TypeError; process_table_data inherits this via sort_data. Please preserve numeric values and handle missing values separately.

@SQLtattoo SQLtattoo closed this Oct 12, 2026
@SQLtattoo
SQLtattoo deleted the demo/budget-buddy-walkthrough branch October 12, 2026 14:04
@SQLtattoo

Copy link
Copy Markdown
Owner Author

demo PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants