Fix: corrected guess responses#164
Closed
the-only-queen-anna wants to merge 1 commit into
Closed
Conversation
…remainingGuesses to GameStateDto
|
the-only-queen-anna
changed the title
Collaborator
Author
|
Closed as duplicate of #166 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
We had a bug, where the backend would not send the updated guess count after a card was revealed. This was corrected. Connected issue: #159
Changes in the codebase
A parameter has been re-added to GameStateDto, that counts the remaining guesses. Previously, only the original guess count was sent. I chose to always send both, to enable a view of the used guesses in respective to the original ones, displayed as
Remaining guesses: 2/3Changes outside the codebase
Added a simple docker-compose file for local development. The container build by this is reachable over
localhost:53213.Start the local container via
docker compose -f docker-compose.dev.yml up -d --build.Additional information
N/A