Fix/163 write to db on card flip#165
Merged
Merged
Conversation
|
XtophB
requested review from
tasaje1 and
the-only-queen-anna
and removed request for
tasaje1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR contains a fix to the DB persistence service.
Description
Originally we would only write to the DB when we change turns. That missed the scenario where the container would crash and players would lose their guessed cards, making the storage of remaining guesses obsolete, as it would always be equal the original guess amount, since we would only save one the turn was over.
Changes in the code base
Changes outside the code base
N/A
Additional information
N/A