Skip to content

Feature/135 delete db entry when lobby deleted#167

Merged
XtophB merged 5 commits into
developmentfrom
feature/135-delete-db-entry-when-lobby-deleted
Jun 12, 2026
Merged

Feature/135 delete db entry when lobby deleted#167
XtophB merged 5 commits into
developmentfrom
feature/135-delete-db-entry-when-lobby-deleted

Conversation

@XtophB

@XtophB XtophB commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

Context

This PR contains the feature to delete lobby entreis from the DB.

Description

When a lobby has no player left, it is closed and deleted. The DB should react accordingly and also delete its entries to not waste space. This PR adds the deletion when in memory lobbies are deleted.

Changes in the code base

  • Add deletion of DB entries to LobbyService
  • Update all classes and test suites that use an actual instance of LobbyService to also take LobbyRepository as a constructor argument
  • Verified that deletion is called when a lobby is deleted

Changes outside the code base

N/A

Additional information

N/A

@XtophB XtophB marked this pull request as draft June 11, 2026 16:09
@XtophB XtophB linked an issue Jun 11, 2026 that may be closed by this pull request
@XtophB XtophB marked this pull request as ready for review June 11, 2026 16:49
@XtophB XtophB marked this pull request as draft June 11, 2026 19:07
@XtophB XtophB marked this pull request as ready for review June 11, 2026 19:15
@sonarqubecloud

Copy link
Copy Markdown

@tasaje1 tasaje1 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@the-only-queen-anna the-only-queen-anna left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XtophB XtophB merged commit aead259 into development Jun 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Löschen von Einträge bei Lobby closing

3 participants