Repository navigation
test: keep test_fanout_stats' orphan workers inside the report day in every timezone - #162
Merged
Merged
Conversation
… every timezone The orphan fixture used 2020-01-02T18:05Z, which is 02:05 on the next local day in Hong Kong, Tokyo and Sydney. The report day is local midnight to local midnight, so the window correctly dropped both workers and 5 assertions failed on any machine at UTC+8 or later (0 failures from UTC-8 to UTC+0). Moved to 09:05Z, which is 2020-01-02 from UTC-5 to UTC+11 and still hours from the other fixture sessions. Verified red before (5 failures each in Asia/Hong_Kong, Asia/Tokyo, Australia/Sydney) and 0 failures after in all seven of New York, Los Angeles, UTC, London, Hong Kong, Tokyo and Sydney.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_fanout_statsintests/run-all.shfailed 5 assertions on any machine at UTC+8 or later. Its orphan workers carried2020-01-02T18:05Z, which is 02:05 on 2020-01-03 in Hong Kong, Tokyo and Sydney. The report day is local midnight to local midnight, so the day window correctly dropped both workers andsessions_nested,fanout_parents, thefanouts.tsvrow count, the group sizes and the orphan names all came up short. Nothing inrun.shis wrong; the fixture assumed a US timezone.The timestamps are now
09:05Z: that is 2020-01-02 locally from UTC-5 to UTC+11, and still hours away from the other fixture sessions (parent at 12:00Z, lone session at 15:00Z), so the test still shows that a fanout is not multi-clauding.Test-only change, one fixture and a comment.
Status
test_fanout_stats, before the changeAsia/Hong_Kong,Asia/TokyoandAustralia/Sydney; 0 inAmerica/New_York,America/Los_Angeles,UTC,Europe/Londontest_fanout_stats, after the changeadapter-claudeneedsps, tworeview-cmuxinteractive assertions, theprune-worktreeswatchdog), so no other test is timezone-sensitive on that evidence.Test plan
test_fanout_statsunderTZ=each of the seven zones above