ci: update gradle workflow and split into jobs

.github/workflows/gradle.yml

@@ -1,81 +1,85 @@
-# This workflow uses actions that are not certified by GitHub.
-# They are provided by a third-party and are governed by
-# separate terms of service, privacy policy, and support
-# documentation.
-# This workflow will build a Java project with Gradle and cache/restore any dependencies to improve the workflow execution time
-# For more information see: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-java-with-gradle
-
 name: Java CI with Gradle
 
 on:
   push:
-    branches: [ "main" ]
   pull_request:
-    branches: [ "main" ]
 
 jobs:
   build:
-
     runs-on: ubuntu-latest
     permissions:
       contents: read
-
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v5
     - name: Set up JDK 17
       uses: actions/setup-java@v4
       with:
         java-version: '17'
         distribution: 'temurin'
-
-    # Configure Gradle for optimal use in GiHub Actions, including caching of downloaded dependencies.
-    # See: https://github.com/gradle/actions/blob/main/setup-gradle/README.md
     - name: Setup Gradle
-      uses: gradle/actions/setup-gradle@ec92e829475ac0c2315ea8f9eced72db85bb337a # v3.0.0
-
+      uses: gradle/actions/setup-gradle@017a9effdb900e5b5b2fddfb590a105619dca3c3 # v4
     - name: Build
       run: ./gradlew build -x test
 
+  test:
+    needs: build
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+    steps:
+    - uses: actions/checkout@v5
+    - name: Set up JDK 17
+      uses: actions/setup-java@v4
+      with:
+        java-version: '17'
+        distribution: 'temurin'
+    - name: Setup Gradle
+      uses: gradle/actions/setup-gradle@017a9effdb900e5b5b2fddfb590a105619dca3c3 # v4
     - name: Copy Z3
       run: ./gradlew copyNativeLibs
-
     - name: Test
       run: ./gradlew test
-
-    - name: Upload test reports if failed
+    - name: Upload test reports
       if: failure()
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: test-reports
-        path: /home/runner/work/SWAT/SWAT/symbolic-executor/build/reports/tests
+        path: symbolic-executor/build/reports/tests
 
-
-    - name: Test
+  javadoc:
+    needs: build
+    if: github.event_name == 'push' && github.ref == 'refs/heads/main'
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+    steps:
+    - uses: actions/checkout@v5
+    - name: Set up JDK 17
+      uses: actions/setup-java@v4
+      with:
+        java-version: '17'
+        distribution: 'temurin'
+    - name: Setup Gradle
+      uses: gradle/actions/setup-gradle@017a9effdb900e5b5b2fddfb590a105619dca3c3 # v4
+    - name: Generate Javadoc
       run: ./gradlew javadoc
-
-
-    - name: Upload javadoc
-      uses: actions/upload-artifact@v3
+    - name: Upload Javadoc
+      uses: actions/upload-artifact@v4
       with:
         name: javadoc
-        path: /home/runner/work/SWAT/SWAT/symbolic-executor/build/docs/javadoc
-
+        path: symbolic-executor/build/docs/javadoc
 
   dependency-submission:
-
+    if: github.event_name == 'push' && github.ref == 'refs/heads/main'
     runs-on: ubuntu-latest
     permissions:
       contents: write
-
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v5
     - name: Set up JDK 17
       uses: actions/setup-java@v4
       with:
         java-version: '17'
         distribution: 'temurin'
-
-    # Generates and submits a dependency graph, enabling Dependabot Alerts for all project dependencies.
-    # See: https://github.com/gradle/actions/blob/main/dependency-submission/README.md
     - name: Generate and submit dependency graph
-      uses: gradle/actions/dependency-submission@ec92e829475ac0c2315ea8f9eced72db85bb337a # v3.0.0
+      uses: gradle/actions/dependency-submission@017a9effdb900e5b5b2fddfb590a105619dca3c3 # v4

settings.gradle

@@ -67,7 +67,7 @@ dependencyResolutionManagement {
             library('asm-util', 'org.ow2.asm','asm-util').versionRef('asm')
             library('asm-tree', 'org.ow2.asm','asm-tree').versionRef('asm')
             library('jackson-databind', 'com.fasterxml.jackson.core:jackson-databind:2.14.1')
-            library('java-smt', 'org.sosy-lab:java-smt:5.0.1')
+            library('java-smt', 'org.sosy-lab:java-smt:6.0.0')
             library('spock-core', 'org.spockframework:spock-core:2.2-M1-groovy-4.0')
             library('mockito-core', 'org.mockito:mockito-core:3.12.4')
             library('logback-classic', 'ch.qos.logback:logback-classic:1.5.3')

symbolic-executor/src/main/java/de/uzl/its/swat/metadata/ClassDepot.java

@@ -66,12 +66,20 @@ public static ClassDepotInstrumentation getInstrumentationInstance() {
 
     /**
      * Registers type metadata (parent and interface names) for a class.
+     * Idempotent: silently returns if the class is already registered with identical metadata.
+     * Asserts if the class is already registered with different metadata.
      */
     public synchronized void registerTypeInfoForClass(String className, List<String> parents, List<String> interfaces) {
         String normalized = Util.formatClassName(className);
+        if (ancestorBaseCache.containsKey(normalized)) {
+            SWATAssert.enforce(
+                    parents.equals(classToParents.get(normalized))
+                            && interfaces.equals(classToInterfaces.get(normalized)),
+                    "Class " + normalized + " already registered in ancestorBaseCache with different metadata");
+            return;
+        }
         classToParents.put(normalized, parents);
         classToInterfaces.put(normalized, interfaces);
-        SWATAssert.enforce(!ancestorBaseCache.containsKey(normalized), "Class " + normalized + " already registered in ancestorBaseCache");
     }
 
     public synchronized List<String> getParentsForClass(String className) {