Repository navigation
🐛 Fix container terminal stdin and bump xterm.js to 6.0.0 - #261
Merged
Merged
Conversation
docker-exec-websocket-server starts the exec stream without Docker's
connection hijack and writes stdin as `write(buffer, { binary: true })`.
On current dockerode/node the first makes writes vanish into an HttpDuplex
that never reaches the container, and the second throws
ERR_UNKNOWN_ENCODING, which the library turns into a closed session: the
shell prompt showed up but typed keys and Enter did nothing. Patch both on
the exec server's own container handle.
Also upgrade xterm.js 5.5.0 -> 6.0.0 (cdnjs ships no minified js for 6.0.0)
and the node-red base image 5.0.4 -> 5.0.6.
lvenier
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tail log at 50 lines.
docker-exec-websocket-server starts the exec stream without Docker's connection hijack and writes stdin as
write(buffer, { binary: true }). On current dockerode/node the first makes writes vanish into an HttpDuplex that never reaches the container, and the second throws ERR_UNKNOWN_ENCODING, which the library turns into a closed session: the shell prompt showed up but typed keys and Enter did nothing. Patch both on the exec server's own container handle.Also upgrade xterm.js 5.5.0 -> 6.0.0 (cdnjs ships no minified js for 6.0.0) and the node-red base image 5.0.4 -> 5.0.6.