Skip to content

Improve mobile landing performance #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SafanDev merged 1 commit into from
Aug 8, 2026
Merged

Improve mobile landing performance #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions final-frame-web/components/public/HomeHero.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,17 +45,7 @@ export default function HomeHero() {
<span>Live review</span>
<span>Review preview</span>
</div>
<div className="ff-home-demo-mobile" aria-label="FinalFrame review preview">
<div>
<span className="ff-live-dot" aria-hidden="true" />
<strong>Campaign launch</strong>
</div>
<span className="ff-status-chip">In review</span>
<p>Versioned work, pinned feedback, and a clear client decision.</p>
</div>
<div className="ff-home-demo-full">
<ReviewPreview />
</div>
<ReviewPreview />
</div>
</section>
);
Expand Down
84 changes: 17 additions & 67 deletions final-frame-web/components/public/ReviewPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,3 @@
const files = [
{ name: "Hero direction", version: "v4", variant: "hero" },
{ name: "Mobile frame", version: "v3", variant: "mobile" },
{ name: "Story crop", version: "v2", variant: "story" },
] as const;

const comments = [
{ marker: 1, author: "Trisha", copy: "Give the headline a little more air." },
{ marker: 2, author: "Nithya", copy: "This direction is ready to approve." },
] as const;

export default function ReviewPreview() {
return (
<div className="ff-review-preview" aria-label="FinalFrame review preview">
Expand All @@ -23,67 +12,28 @@ export default function ReviewPreview() {
<span className="ff-status-chip">In review</span>
</div>

<div className="ff-review-preview-grid">
<aside className="ff-review-files" aria-label="Preview files">
<p className="ff-preview-section-label">Files</p>
<div className="ff-preview-file-list">
{files.map((item, index) => (
<div
key={item.name}
className={`ff-preview-file${index === 0 ? " is-active" : ""}`}
>
<span className={`ff-preview-file-thumb is-${item.variant}`} aria-hidden="true" />
<span className="ff-preview-file-copy">
<strong>{item.name}</strong>
<small>{item.version}</small>
</span>
</div>
))}
</div>
</aside>

<div className="ff-review-stage">
<div className="ff-review-artboard is-hero">
<span className="ff-artboard-kicker">NORTH / 24</span>
<h2>Make the next frame matter.</h2>
<div className="ff-artboard-shapes" aria-hidden="true">
<span />
<span />
</div>
<span className="ff-preview-pin pin-one" aria-hidden="true">1</span>
<span className="ff-preview-pin pin-two" aria-hidden="true">2</span>
<span className="ff-artboard-hint" aria-hidden="true">Pinned feedback</span>
</div>

<div className="ff-review-stage-tools" aria-hidden="true">
<span className="is-active">Fit</span>
<span>100%</span>
<span>Compare</span>
</div>
<div className="ff-review-preview-body">
<div className="ff-review-artboard" aria-hidden="true">
<span className="ff-artboard-kicker">NORTH / 24</span>
<strong>Make the next frame matter.</strong>
<span className="ff-preview-pin pin-one">1</span>
<span className="ff-preview-pin pin-two">2</span>
</div>

<aside className="ff-review-feedback" aria-label="Preview feedback">
<div className="ff-preview-feedback-head">
<p className="ff-preview-section-label">Feedback</p>
<span>{comments.length} open</span>
<div className="ff-review-preview-summary" aria-label="Review status summary">
<div>
<span>Files</span>
<strong>3 versions</strong>
</div>
<div className="ff-preview-comment-list">
{comments.map((comment) => (
<div className="ff-preview-comment" key={`${comment.marker}-${comment.author}`}>
<span>{String(comment.marker).padStart(2, "0")}</span>
<div>
<strong>{comment.author}</strong>
<p>{comment.copy}</p>
</div>
</div>
))}
<div>
<span>Feedback</span>
<strong>2 open</strong>
</div>
<div className="ff-preview-approval">
<span>Final decision</span>
<strong>Waiting for client</strong>
<span className="ff-preview-approval-action" aria-hidden="true">Approve frame</span>
<div>
<span>Decision</span>
<strong>Waiting</strong>
</div>
</aside>
</div>
</div>
</div>
);
Expand Down
Loading