[SYNPY-1784] Added delete_record_set and delete_file_view parameters to CurationTask.delete()#1333
Merged
andrewelamb merged 6 commits intodevelopfrom Mar 4, 2026
Merged
[SYNPY-1784] Added delete_record_set and delete_file_view parameters to CurationTask.delete()#1333andrewelamb merged 6 commits intodevelopfrom
andrewelamb merged 6 commits intodevelopfrom
Conversation
andrewelamb
changed the title
thomasyu888
reviewed
Mar 3, 2026
Member
thomasyu888
left a comment
thomasyu888
left a comment
There was a problem hiding this comment.
Great to see this - I have one comment and I'll defer to the team for final review
linglp
reviewed
Mar 4, 2026
Contributor
linglp
left a comment
linglp
left a comment
There was a problem hiding this comment.
Hi @andrewelamb ! Thanks for your hard work. I left some comments about the tests. Could you also update metadata_curation.md to make sure that we have a section about deleting curation tasks? Thanks
linglp
reviewed
Mar 4, 2026
| # Clean up temporary file | ||
| if os.path.exists(temp_csv): | ||
| os.unlink(temp_csv) | ||
|
|
Contributor
There was a problem hiding this comment.
Should the script here: create_file_based_metadata_task also be updated?
thomasyu888
approved these changes
Mar 4, 2026
linglp
approved these changes
Mar 4, 2026
Contributor
linglp
left a comment
linglp
left a comment
There was a problem hiding this comment.
LGTM! The fix of integration will be done in a separate ticket: https://sagebionetworks.jira.com/browse/SYNPY-1788
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
Data managers would like to make the cleanup of Curation tasks easier.
Solution:
delete_record_setparameter deletes the associatedRecordSetentity.delete_file_viewparameter deletes the associatedFileViewentity.Testing:
Integration tests were added/modified for:
delete_record_setparameterdelete_file_viewparameter