[SYNPY-1787] Changed conditionals so that the watched property is required

[andrewelamb]

Problem:

Conditional properties like:

    "if":{
                "properties":{
                    "Diagnosis":{
                        "enum":[
                            "Cancer"
                        ]
                    }
                }
            },
            "then":{
                "properties":{
                    "FamilyHistory":{
                        "not":{
                            "type":"null"
                        }
                    }
                },
                    "required":["FamilyHistory"]

weren't quite working right in the Curator UI. The watched property needs to be required:

"if":{
                "properties":{
                    "Diagnosis":{
                        "enum":[
                            "Cancer"
                        ]
                    }
                },
                "required": ["Diagnosis"]
            },
            "then":{
                "properties":{
                    "FamilyHistory":{
                        "not":{
                            "type":"null"
                        }
                    }
                },
                    "required":["FamilyHistory"]
            }

Solution:

The function that creates conditionals has been changed to add the required statement to the if statement.

Testing:

The existing tests have been updated.

[BryanFauble]

LGTM! Nice fix — adding required to the if block is the right approach per the JSON Schema spec. The Jira ticket writeup was really thorough too, thanks for that.

Note: This comment was drafted with AI assistance and reviewed by me for accuracy.

[linglp]

@andrewelamb sorry I was a bit late to this. Could you also update the documentation here: https://synapsepythonclient--1334.org.readthedocs.build/en/1334/explanations/curator_data_model/?h=conditional#conditional-dependencies

[andrewelamb]

@linglp Not a problem!