Repository navigation
Improve GitHub Actions workflows based on zizmor static analysis - #98
Merged
Merged
Conversation
Added empty `permissions: {}` blocks to all workflows to prevent
unintended/unexpected default permissions from leaking in. This was a
recommendation from the zizmor auditor persona. This change aligns the
workflows with the latest recommendations for fine-grained permissions
configuration.
Annotated `uses` steps in all GitHub Actions workflows that call UBC-MOAD reusable workflows with `zizmor: ignore[unpinned-uses]` comments. This suppresses the auditor warning about unpinned actions and aligns with our current workflow configuration practice of trusting our own workflows.
Added comments explaining the rationale for each `permissions` setting in all GitHub Actions workflows. This improves clarity and aligns with best practices for fine-grained permissions configuration.
Updated all workflows to include a meaningful `name` field for each job. This enhances readability and makes the workflow steps easier to understand in the GitHub Actions UI.
douglatornell
added
maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zizmorto ignore unpinned uses of our own reusable workflows