Skip to content

Fix _encode_identifier to always emit valid identifiers#36

Open
dakerfp wants to merge 1 commit intoSanDisk-Open-Source:masterfrom
dakerfp:patch-1
Open

Fix _encode_identifier to always emit valid identifiers#36
dakerfp wants to merge 1 commit intoSanDisk-Open-Source:masterfrom
dakerfp:patch-1

Conversation

@dakerfp
Copy link

@dakerfp dakerfp commented Feb 13, 2025

No description provided.

@jpgrayson
Copy link
Collaborator

From ieee 1364-2001:

The value change dumper generates character identifier codes to represent variables. The identifier code is a
code composed of the printable characters which are in the ASCII character set from ! to ~ (decimal 33 to
126).

This PR changes VCDWriter such that identifier codes always start with A-z, but the spec does not require this.

Is there some application that has trouble with [standards compliant] base-94 identifier codes? What is this fixing?

@dakerfp
Copy link
Author

dakerfp commented Aug 12, 2025

pyvcd.reader itself doesn't work with identifier codes starting out of the A-z range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants