Fix _encode_identifier to always emit valid identifiers#36
Open
dakerfp wants to merge 1 commit intoSanDisk-Open-Source:masterfrom
Open
Fix _encode_identifier to always emit valid identifiers#36dakerfp wants to merge 1 commit intoSanDisk-Open-Source:masterfrom
dakerfp wants to merge 1 commit intoSanDisk-Open-Source:masterfrom
Conversation
Collaborator
|
From ieee 1364-2001:
This PR changes Is there some application that has trouble with [standards compliant] base-94 identifier codes? What is this fixing? |
Author
|
pyvcd.reader itself doesn't work with identifier codes starting out of the A-z range. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.