[WIP] Removed localStorage save but added an option to collapse groups on load#12
Open
KittyGiraudel wants to merge 2 commits intodevelopfrom
Open
[WIP] Removed localStorage save but added an option to collapse groups on load#12KittyGiraudel wants to merge 2 commits intodevelopfrom
KittyGiraudel wants to merge 2 commits intodevelopfrom
Conversation
KittyGiraudel
force-pushed
the
develop
branch
from
d067476 to
cd41e26
Compare
Member
Author
|
I need to run some extra tests on this. |
KittyGiraudel
changed the title
Contributor
|
I do think it should be kept in memory. Otherwise you might as well remove the collapsing feature altogether. |
Member
Author
|
The thing is localStorage saving bothered me more than once. Maybe I only need to put some extra love to the implementation. |
|
I'm not seeing an |
|
+1 for collapsed on load. |
|
I need this feature :) |
Member
Author
|
Good morning! Unfortunately, I do not have time anymore to work on SassDoc. :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided to remove the localStorage thingie. It adds some extra complexity that I feel is not worth the trouble. If someone really think we should keep the current sidebar state in localStorage, please feel free to ask.
Although I added a way to collapse all groups on load. This is done through the
initialSidebarCollapseoption (boolean). If someone has a better name for it, please share. :)