Skip to content

Use Kokkos::Parallel in ResidualGive#242

Draft
julianlitz wants to merge 4 commits into
mainfrom
litz_010
Draft

Use Kokkos::Parallel in ResidualGive#242
julianlitz wants to merge 4 commits into
mainfrom
litz_010

Conversation

@julianlitz
Copy link
Copy Markdown
Collaborator

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.13%. Comparing base (5952563) to head (d5c13a2).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
- Coverage   90.72%   90.13%   -0.59%     
==========================================
  Files          86       80       -6     
  Lines        9473     8878     -595     
==========================================
- Hits         8594     8002     -592     
+ Misses        879      876       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread include/Residual/ResidualGive/applyAGive.inl Outdated
Comment on lines +307 to +308
const LevelCacheType* level_cache_ptr = &level_cache;
const PolarGrid* grid_ptr = &grid;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in a different PR, the use of pointers will prevent this from working on GPU

Copy link
Copy Markdown
Collaborator Author

@julianlitz julianlitz May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the Grid pointer already works. The data will not be copied.

But doing the same for the LevelCache not quite:
We need to change the LevelCache member to AllocatableVector so no new copies are made.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to change the LevelCache member to AllocatableVector so no new copies are made.

I don't understand why this would be the case.

We do need to remove references from LevelCache though

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test it yet. But before merging we just need to be sure that LevelCache isn't fully copied when parsed to a kokkos lambda

Co-authored-by: Emily Bourne <emily.bourne@epfl.ch>
@julianlitz
Copy link
Copy Markdown
Collaborator Author

Moved to #256

@julianlitz julianlitz marked this pull request as draft May 11, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants