Use Kokkos::Parallel in ResidualGive#242
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
==========================================
- Coverage 90.72% 90.13% -0.59%
==========================================
Files 86 80 -6
Lines 9473 8878 -595
==========================================
- Hits 8594 8002 -592
+ Misses 879 876 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| const LevelCacheType* level_cache_ptr = &level_cache; | ||
| const PolarGrid* grid_ptr = &grid; |
There was a problem hiding this comment.
As mentioned in a different PR, the use of pointers will prevent this from working on GPU
There was a problem hiding this comment.
Removing the Grid pointer already works. The data will not be copied.
But doing the same for the LevelCache not quite:
We need to change the LevelCache member to AllocatableVector so no new copies are made.
There was a problem hiding this comment.
We need to change the LevelCache member to AllocatableVector so no new copies are made.
I don't understand why this would be the case.
We do need to remove references from LevelCache though
There was a problem hiding this comment.
I didn't test it yet. But before merging we just need to be sure that LevelCache isn't fully copied when parsed to a kokkos lambda
Co-authored-by: Emily Bourne <emily.bourne@epfl.ch>
|
Moved to #256 |
Merge Request - GuideLine Checklist
Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.
Checks by code author:
Always to be checked:
If functions were changed or functionality was added:
If new functionality was added:
If new third party software is used:
If new mathematical methods or epidemiological terms are used:
Checks by code reviewer(s):