Skip to content

Use KOKKOS_CLASS_LAMBDA to access class members#251

Open
EmilyBourne wants to merge 8 commits into
mainfrom
ebourne_class_lambda
Open

Use KOKKOS_CLASS_LAMBDA to access class members#251
EmilyBourne wants to merge 8 commits into
mainfrom
ebourne_class_lambda

Conversation

@EmilyBourne
Copy link
Copy Markdown
Collaborator

Use KOKKOS_CLASS_LAMBDA to copy class instance to access class members

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@EmilyBourne EmilyBourne requested a review from julianlitz May 8, 2026 09:33
@EmilyBourne EmilyBourne marked this pull request as draft May 11, 2026 15:26
@EmilyBourne EmilyBourne marked this pull request as ready for review May 12, 2026 10:19
@julianlitz
Copy link
Copy Markdown
Collaborator

@EmilyBourne do the functions inside the kokkos class lambdas need to be public as you suggested few days ago?

@EmilyBourne
Copy link
Copy Markdown
Collaborator Author

@EmilyBourne do the functions inside the kokkos class lambdas need to be public as you suggested few days ago?

No, the functions inside the kokkos class lambdas should be ok. But the lambdas need to be in a function who's address can be taken. So a public method that is not a constructor. You can see the associated error in several of the other open PRs

@EmilyBourne EmilyBourne marked this pull request as draft May 12, 2026 10:31
@EmilyBourne EmilyBourne marked this pull request as ready for review May 12, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants