Skip to content

Fix cuda compilation#257

Open
EmilyBourne wants to merge 5 commits into
litz_020from
ebourne_litz_020_cuda
Open

Fix cuda compilation#257
EmilyBourne wants to merge 5 commits into
litz_020from
ebourne_litz_020_cuda

Conversation

@EmilyBourne
Copy link
Copy Markdown
Collaborator

Merge Request - GuideLine Checklist

Guideline to check code before resolve WIP and approval, respectively.
As many checkboxes as possible should be ticked.

Checks by code author:

Always to be checked:

  • There is at least one issue associated with the pull request.
  • New code adheres with the coding guidelines
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

If functions were changed or functionality was added:

  • Tests for new functionality has been added
  • A local test was succesful

If new functionality was added:

  • There is appropriate documentation of your work. (use doxygen style comments)

If new third party software is used:

  • Did you pay attention to its license? Please remember to add it to the wiki after successful merging.

If new mathematical methods or epidemiological terms are used:

  • Are new methods referenced? Did you provide further documentation?

Checks by code reviewer(s):

  • Is the code clean of development artifacts e.g., unnecessary comments, prints, ...
  • The ticket goals for each associated issue are reached or problems are clearly addressed (i.e., a new issue was introduced).
  • There are appropriate unit tests and they pass.
  • The git history is clean and linearized for the merge request. All reviewers should squash commits and write a simple and meaningful commit message.
  • Coverage report for new code is acceptable.
  • No large data files have been added to the repository. Maximum size for files should be of the order of KB not MB. In particular avoid adding of pdf, word, or other files that cannot be change-tracked correctly by git.

@EmilyBourne EmilyBourne force-pushed the ebourne_litz_020_cuda branch from e7fa5ac to 995020c Compare May 12, 2026 13:08
@EmilyBourne
Copy link
Copy Markdown
Collaborator Author

@julianlitz This PR fixes the cuda compilation in #256 but it doesn't change the logic. The tests are already failing in #256

@julianlitz
Copy link
Copy Markdown
Collaborator

@EmilyBourne Alright I will fix that

@julianlitz
Copy link
Copy Markdown
Collaborator

image

@EmilyBourne Claude found the issue. It is now hopefully fixed

@julianlitz
Copy link
Copy Markdown
Collaborator

Oh you already added these fence() calls... 🫠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants