Repository navigation
Conversation
…d config.json - Find likwid with FindLikwid.cmake and link the imported target likwid::likwid, also for installed packages - Update Google Benchmark to v1.9.5 - memilio-generation: stop tracking the generated config.json, find libclang next to the compiler, remove invalid install RPATH
MEMILIO_BUILD_SHARED_LIBS now defaults to OFF with MSVC, so Windows builds no longer warn on every configure. The warning remains if ON is set explicitly.
xsaschako
marked this pull request as ready for review
October 12, 2026 08:25
# Conflicts: # pycode/memilio-generation/CMakeLists.txt
Configured headers get their own file set, as base directories of one file set must not be nested.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1596 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 190 190
Lines 16048 16048
=======================================
Hits 15655 15655
Misses 393 393 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes and Information
FILE_SETheaders,COMPILE_WARNING_AS_ERROR,PROJECT_IS_TOP_LEVELandSYSTEM/EXCLUDE_FROM_ALLfor FetchContent dependenciesfind_package(memilio), relocatable RPATH, C++20 propagated viacxx_std_20memilio_add_model()helper and new optionMEMILIO_ENABLE_INSTALL; remove no-opMEMILIO_BUILD_STATIC_LIBSReviewers: Windows/MSVC, system Boost, Ipopt and SBML builds were not tested locally.
Merge Request - Guideline Checklist
Please check our git workflow. Use the draft feature if the Pull Request is not yet ready to review.
Checks by code author
Checks by code reviewer(s)
Closes #506
Closes #647
Related to #89